]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
dash: Make sure _clearDragPlaceholder() resets _dragPlaceholderPos
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 31 May 2013 15:47:48 +0000 (17:47 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Wed, 5 Jun 2013 13:32:43 +0000 (15:32 +0200)
The function currently only resets the placeholder position if
there is a placeholder; this is not necessarily true, as the
placeholder may be reset outside _clearDragPlaceholder().
If this happens, the placeholder will temporarily stop working
for the "old" position (and permanently if it's the only position).
Just reset the position unconditionally.

https://bugzilla.gnome.org/show_bug.cgi?id=684618

js/ui/dash.js

index e29aff4041721f30d700b4e4f57c5eed0386533f..d6fd14cfff317b2dc0b9230a9bcf1c32e08d16da 100644 (file)
@@ -793,8 +793,8 @@ const Dash = new Lang.Class({
         if (this._dragPlaceholder) {
             this._dragPlaceholder.animateOutAndDestroy();
             this._dragPlaceholder = null;
-            this._dragPlaceholderPos = -1;
         }
+        this._dragPlaceholderPos = -1;
     },
 
     handleDragOver : function(source, actor, x, y, time) {